Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge GDB tests into one #245

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Merge GDB tests into one #245

merged 1 commit into from
Oct 16, 2024

Conversation

wsipak
Copy link
Collaborator

@wsipak wsipak commented Oct 14, 2024

All the GDB run the same program which just loops endlessly. The actual behavior that we want to use for testing is in the GDB scripts. Let's combine the GDB scripts which read registers, operate on memory and set breakpoints into a single script.

There's one test that takes too long and has already been marked with a TODO to remove it because the previous tests do the job.

@wsipak wsipak force-pushed the wsip/drop_periph_test branch from 9e0308e to aaaf89a Compare October 14, 2024 10:36
@wsipak wsipak changed the title remove unneeded test from gdb tests Merge GDB tests into one Oct 14, 2024
@wsipak wsipak marked this pull request as ready for review October 14, 2024 14:15
Copy link

Links to coverage and verification reports for this PR (#245) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

@wsipak wsipak force-pushed the wsip/drop_periph_test branch from 59ebdd3 to 71221cb Compare October 14, 2024 14:29
Copy link

Links to coverage and verification reports for this PR (#245) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

1 similar comment
Copy link

Links to coverage and verification reports for this PR (#245) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

Let's merge and shorten the GDB tests.
We should perform all the tasks withing one GDB script.
End the simulation by writing 0xff to proper address
instead of waiting for it to end.
@wsipak wsipak force-pushed the wsip/drop_periph_test branch from 71221cb to a9658b8 Compare October 15, 2024 08:09
Copy link

Links to coverage and verification reports for this PR (#245) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

Copy link
Collaborator

@tmichalak tmichalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmichalak tmichalak merged commit d22fa40 into main Oct 16, 2024
578 checks passed
@wsipak wsipak deleted the wsip/drop_periph_test branch November 14, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants